Skip to content

Commit

Permalink
Fix set immediate value (#432)
Browse files Browse the repository at this point in the history
* fix set immediate value
  • Loading branch information
KazuCocoa authored Dec 22, 2016
1 parent 75acc43 commit ab3ba8e
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 3 deletions.
10 changes: 10 additions & 0 deletions android_tests/lib/android/specs/android/element/textfield.rb
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,15 @@ def after_last
hide_keyboard
end

t 'set_immediate_value' do
message = 'hello'

wait do
elem = textfield(1)
set_immediate_value(elem, message)
elem.text.must_equal message
end
end

t { after_last }
end
16 changes: 16 additions & 0 deletions ios_tests/lib/ios/specs/ios/element/textfield.rb
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,22 @@ def must_raise_no_element
textfields_exact('does not exist').length.must_equal 0
end

t 'set_immediate_value' do
go_to_textfields

message = 'hello'

element = textfield(1)
element.click
element.clear

set_immediate_value(element, message)
element.text.must_equal message

set_wait 10
leave_textfields
end

t 'after_last' do
after_last
end
Expand Down
14 changes: 11 additions & 3 deletions lib/appium_lib/device/device.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,18 @@ def long_press_keycode(key, metastate = nil)
end
end

# TODO: TEST ME
# @!method set_immediate_value
# Set the value to element directly
# for iOS; setValue is called in XCUITest instead because XCUITest doesn't provide set value directly.
# https://github.com/appium/appium-xcuitest-driver/blob/793cdc7d5e84bd553e375076e1c6dc7e242c9cde/lib/commands/element.js#L123
#
# ```ruby
# set_immediate_value element, 'hello'
# ```
add_endpoint_method(:set_immediate_value) do
def set_immediate_value(element, value)
execute :set_immediate_value, { id: element.ref }, value: value
def set_immediate_value(element, *value)
keys = ::Selenium::WebDriver::Keys.encode(value)
execute :set_immediate_value, { id: element.ref }, value: Array(keys)
end
end

Expand Down

0 comments on commit ab3ba8e

Please sign in to comment.