Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstraps should be thread-safe/Sendable #2846

Open
weissi opened this issue Aug 18, 2024 · 2 comments
Open

Bootstraps should be thread-safe/Sendable #2846

weissi opened this issue Aug 18, 2024 · 2 comments

Comments

@weissi
Copy link
Member

weissi commented Aug 18, 2024

NIO's bootstraps have traditionally not been thread-safe (and therefore aren't Sendable either). I'm not so sure anymore if that was historically an accident or deliberate :).

FWIW, Netty's are thread-safe: netty/netty#14063

@Lukasa
Copy link
Contributor

Lukasa commented Aug 18, 2024

It’s an accident. Their current non-Sendability is a reflection of their actual implementation, but we shouldn’t keep it that way.

@weissi
Copy link
Member Author

weissi commented Aug 19, 2024

It’s an accident. Their current non-Sendability is a reflection of their actual implementation, but we shouldn’t keep it that way.

Okay, sounds good. I'll retitle this issue then.

@weissi weissi changed the title Should bootstraps be thread-safe/Sendable Bootstraps should be thread-safe/Sendable Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants