Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assist with librarian-chef issue #57 #181

Open
tenaciousRas opened this issue Sep 23, 2016 · 0 comments
Open

Assist with librarian-chef issue #57 #181

tenaciousRas opened this issue Sep 23, 2016 · 0 comments

Comments

@tenaciousRas
Copy link

tenaciousRas commented Sep 23, 2016

I filed issue #57 in librarian-chef at applicationsonline/librarian-chef#57. Upon further inspection it looks like this might be an issue with librarian. Other librarian plugins such as librarian-puppet might exhibit the same issue, although I haven't verified.

Specifically it looks like the method Clean#clean_install_path;21-28 does the nuking (permanently deletes work).

https://github.com/applicationsonline/librarian/blob/b968cd91a3955657bf6ea728b922f2cb74843264/lib/librarian/action/clean.rb

If I'm right then what concerns me is how to patch it in this architecture. How does librarian tell plugins like librarian-chef that a call to clean_install_path either requires librarian-chef to prompt the user or provide an override before potentially nuking the current working directory?

Please advise as to whether the original bug report is filed in the proper project, and/or any suggestions for a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant