Add --force flag when removing snapshots #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to force removal of snapshots if specified
apprell
requested changes
Feb 17, 2025
| @@ -236,6 +237,8 @@ def remove_snapshot(vmid: str, virtualization: str, label: str = 'daily', keep: | |||
| if old_snapshots: | |||
| for old_snapshot in old_snapshots: | |||
| params = [virtualization, 'delsnapshot', vmid, old_snapshot] | |||
| if FORCE: | |||
| params.extend(["--force", "true"]) | |||
There was a problem hiding this comment.
Hey! The general code style uses single quotes. Could you replace the double quotes in --force and true with single quotes to keep it consistent? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to force removal of snapshots if specified
I tested this on our production cluster and seems to be working well. I had an issue where a heap of our VMs deleted the ZFS snapshot but not the snapshot in Proxmox, not sure why.