-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Peek overlay of entity and bindings #17507
Labels
Enhancement
New feature or request
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Comments
kocharrahul7
added
Enhancement
New feature or request
IDE Pod
Issues that new developers face while exploring the IDE
labels
Oct 12, 2022
kocharrahul7
added
the
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
label
Oct 12, 2022
github-actions
bot
removed
the
IDE Pod
Issues that new developers face while exploring the IDE
label
Oct 12, 2022
eco-monk
added
the
IDE Pod
Issues that new developers face while exploring the IDE
label
Oct 12, 2022
@aakashDesign Please add the final designs on this issue |
Can be taken later: |
This was referenced Jan 10, 2023
Discussed last week during a IDE weekly meet: (sorry for posting late, I forgot to update this) |
Progress so far last week:
|
https://mac-s-g.github.io/react-json-view/demo/dist/ cc: @shwetha-ramesh |
eco-monk
added a commit
that referenced
this issue
Feb 17, 2023
## Description Hover over appsmith properties in code to peek data. <img width="380" alt="image" src="https://user-images.githubusercontent.com/66776129/217707810-164924c0-36e8-4450-b087-18af333c7547.png"> This right now covers: - Queries/JsObjects/Apis/Widgets and their properties. - Note: For query or Api, this'll work only upto `Api.data`. (Not `Api.data.users[0].id`) - This is because of the way codemirror renders code and we'll need more time to see how this is best handled. Misc: - added `react-append-to-body` to work with variable height for peek overlay - we needed a container that doesn't apply `position: absolute` to itself - Because, when a container's `height` is zero with `position: absolute` (like in bp3-portal), child elements cannot be positioned using just the `bottom` property - with `react-append-to-body`, the container won't have `position: absolute`, instead it is applied to the child element `<div>` directly, hence we can position using `bottom` property. Fixes #17507 Media https://www.loom.com/share/0f17918fcd604805b023c215d57fce43 ## Type of change - New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Manual ### Test Plan https://github.com/appsmithorg/TestSmith/issues/2173 https://github.com/appsmithorg/TestSmith/issues/2178 ### Issues raised during DP testing #20053 (comment) #20053 (comment) ## Checklist: ### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag ### QA activity: - [x] Test plan has been approved by relevant developers - [ ] Test plan has been peer reviewed by QA - [x] Cypress test cases have been added and approved by either SDET or manual QA - [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA - [ ] Added Test Plan Approved label after reveiwing all Cypress test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
New feature or request
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Is there an existing issue for this?
Summary
When hovering on an entity name (Widget, or action) in appsmith, it would be great if we peek into the value of the entity. For instance, while hovering on api1, I should be able to understand and access the values associated with API1. I should be able to see api1.data, the return type, and the info associated with it.
Handover file
https://zpl.io/o14Ww3Z
Why should this be worked on?
As a user, if I am looking at an app, and see bindings utils.data, I have no idea if utlis is a jsObject, or a query. I don't know the data which it is returning, and I don't know much about what it does. It would be a great way to peek into each variable and helps create visibility and understanding of what each binding is.
Questions and clarifications:
API1.data
, and hovers onAPI1
, we will just highlightAPI1
. If the user hovers on data, we will highlight justdata
The text was updated successfully, but these errors were encountered: