diff --git a/.golangci.yml b/.golangci.yml index 251ceef2c7..8cf176c907 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -18,9 +18,9 @@ linters: - lll # TODO: fixme + - godox - gochecknoglobals - gochecknoinits - - unparam - goconst - gocognit - errcheck diff --git a/cmd/bank-vaults/util.go b/cmd/bank-vaults/util.go index ee43dfb14c..fd4a2b938c 100644 --- a/cmd/bank-vaults/util.go +++ b/cmd/bank-vaults/util.go @@ -35,8 +35,9 @@ import ( "github.com/banzaicloud/bank-vaults/pkg/sdk/vault" ) -func vaultConfigForConfig(cfg *viper.Viper) (vault.Config, error) { - +// TODO review this function's returned error +// nolint: unparam +func vaultConfigForConfig(_ *viper.Viper) (vault.Config, error) { return vault.Config{ SecretShares: appConfig.GetInt(cfgSecretShares), SecretThreshold: appConfig.GetInt(cfgSecretThreshold), diff --git a/cmd/vault-secrets-webhook/configmap.go b/cmd/vault-secrets-webhook/configmap.go index d422aefb1b..326cedd409 100644 --- a/cmd/vault-secrets-webhook/configmap.go +++ b/cmd/vault-secrets-webhook/configmap.go @@ -39,8 +39,7 @@ func configMapNeedsMutation(configMap *corev1.ConfigMap) bool { return false } -func mutateConfigMap(configMap *corev1.ConfigMap, vaultConfig internal.VaultConfig, ns string) error { - +func mutateConfigMap(configMap *corev1.ConfigMap, vaultConfig internal.VaultConfig, _ string) error { // do an early exit and don't construct the Vault client if not needed if !configMapNeedsMutation(configMap) { return nil diff --git a/cmd/vault-secrets-webhook/secret.go b/cmd/vault-secrets-webhook/secret.go index b8e653fbad..5ca86d4ced 100644 --- a/cmd/vault-secrets-webhook/secret.go +++ b/cmd/vault-secrets-webhook/secret.go @@ -39,8 +39,7 @@ func secretNeedsMutation(secret *corev1.Secret) bool { return false } -func mutateSecret(secret *corev1.Secret, vaultConfig internal.VaultConfig, ns string) error { - +func mutateSecret(secret *corev1.Secret, vaultConfig internal.VaultConfig, _ string) error { // do an early exit and don't construct the Vault client if not needed if !secretNeedsMutation(secret) { return nil @@ -139,6 +138,8 @@ func mutateSecretData(secret *corev1.Secret, sc map[string]string, vaultClient * return nil } +// TODO review this function's returned error +// nolint: unparam func getDataFromVault(data map[string]string, vaultClient *vault.Client) (map[string]string, error) { var vaultData = make(map[string]string) @@ -170,6 +171,7 @@ func getDataFromVault(data map[string]string, vaultClient *vault.Client) (map[st secret, err := vaultClient.RawClient().Logical().ReadWithData(path, map[string][]string{"version": {version}}) if err != nil { logger.Errorf("Failed to read secret path: %s error: %s", path, err.Error()) + // TODO return error? } if secret == nil { logger.Errorf("Path not found path: %s", path)