Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pandas nullable integer for position in for normalized snps dataframe #109

Open
afaulconbridge opened this issue Nov 7, 2020 · 1 comment
Milestone

Comments

@afaulconbridge
Copy link
Contributor

Along the same lines as #108 has it been considered to use the Pandas nullable integer datatype (pd.Int64Dtype()) for pos? More details here. We've seen a number of files that fail to parse because the position information for a small number of rows is missing (for example, on a RSID with multiple possible locations).

@apriha
Copy link
Owner

apriha commented Nov 9, 2020

Interesting. Yes a nullable integer dtype would be good to handle these cases. But let's go with pd.UInt32Dtype(), which would minimize memory usage.

@apriha apriha added this to the 3.0.0 milestone Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants