Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failures with ruby 2.5.1 #18

Open
Crisfole opened this issue Aug 28, 2018 · 1 comment
Open

Test Failures with ruby 2.5.1 #18

Crisfole opened this issue Aug 28, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@Crisfole
Copy link
Contributor

To reproduce:

if rbenv versions | grep 2.5.1 -q; then
  echo '2.5.1 already installed'
else
  rbenv install 2.5.1
fi
rbenv local 2.5.1
bin/setup
bundle exec appraisal rake test

You'll get a SystemStackError because of the ::Bignum ::Fixnum merge. I don't fully understand the issue because I stopped reading the explanation, but it has to do with rails < 5.0 and ruby >= 2.4.0 and how rails sniffs integer types (https://stackoverflow.com/a/41504382/456188).

@wkirby
Copy link
Contributor

wkirby commented Nov 15, 2018

Gross.

@wkirby wkirby added the bug label Nov 15, 2018
@wkirby wkirby added this to the 0.4.0 milestone Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants