Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting feedback #105

Open
qris opened this issue Apr 5, 2013 · 4 comments
Open

Allow deleting feedback #105

qris opened this issue Apr 5, 2013 · 4 comments
Labels

Comments

@qris
Copy link
Collaborator

qris commented Apr 5, 2013

It's important to be able to delete your own feedback, especially a consent (e.g. if someone edits the proposal and you can no longer agree to it).

@birdsarah
Copy link
Collaborator

Hi qris, Nate/AlanHamish? wrote a really nice email a while back (or maybe it was an apticon thing - can't remember) about why econsensus needs improvement to support real decision making. I seem to not be able to remember who said it and when, but the point was this.

Concern & Consent are states
Other things are feedback

So you can have a long discussion about proposals with "comments / questions" and then change your state multiple times.

I think this would be better than allowing deleting feedback.

@qris
Copy link
Collaborator Author

qris commented Apr 5, 2013

Perhaps that's another way to achieve this, I don't mind as long as one or other of these gets done quite quickly. I think deleting your own feedback is useful anyway (since you can edit it and remove all the text) and very easy to do compared to making consent into a state.

@jogwen
Copy link
Collaborator

jogwen commented Apr 11, 2013

cc-ing econsensus-discuss in case non git users wish to express opinions,
plus not sure if Tom Lord gets these github notifications.

I see your point Chris. I guess you could go back and alter the rating of
your feedback (eg. from Consent to Danger), but this will confuse any
discussion that's taken place under that feedback so that it will no longer
make much sense. My concern with allowing deletion of feedbacks is what to
do with any related comments, do we delete them too? Or prevent deletion of
feedbacks if they've been commented on? Or leave the comments visible but
without the context feedback item? The latter would be the equivalent of
just deleting the content of the feedback as is possible currently.

I can see the logic of having Consent, Concern and Danger as statuses
rather than feedbacks, but I can see a need for a feedback/comment style
discussion related to any of these statuses (describing and discussing
reasons for the status, possible amendments that would enable consent etc).
Perhaps we should preserve feedback/comment conversations as they are to
prevent later edits losing the original jist of the conversation, but then
allow an user that's already posted a Consent/Concern/Danger to then post a
different status later on, so that the later status supercedes the original

  • the summary at the top could be altered to only count the latest status
    for each user, and we could maybe fade out the superceded statuses using
    styling, so that it's clear what they were originally but that they're no
    longer applicable?

On 5 April 2013 16:52, Chris Wilson [email protected] wrote:

Perhaps that's another way to achieve this, I don't mind as long as one or
other of these gets done quite quickly. I think deleting your own feedback
is useful anyway (since you can edit it and remove all the text) and very
easy to do compared to making consent into a state.


Reply to this email directly or view it on GitHubhttps://github.com//issues/105#issuecomment-15963871
.

@qris
Copy link
Collaborator Author

qris commented Apr 11, 2013

Hi Jo,

On Thu, 11 Apr 2013, jogwen wrote:

I can see the logic of having Consent, Concern and Danger as statuses
rather than feedbacks, but I can see a need for a feedback/comment style
discussion related to any of these statuses (describing and discussing
reasons for the status, possible amendments that would enable consent etc).
Perhaps we should preserve feedback/comment conversations as they are to
prevent later edits losing the original jist of the conversation, but then
allow an user that's already posted a Consent/Concern/Danger to then post a
different status later on, so that the later status supercedes the original

  • the summary at the top could be altered to only count the latest status
    for each user, and we could maybe fade out the superceded statuses using
    styling, so that it's clear what they were originally but that they're no
    longer applicable?

I'd be happy for the summary at the top to only count the latest status,
and fade out all the others somewhat.

Cheers, Chris.


\ / / ,() | Chris Wilson [email protected] Cambs UK |
/ (/ ,/ / / \ | Security/C/C++/Java/Ruby/Perl/SQL Developer |
__/
/////__/ | We are GNU : free your mind & your software |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants