Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prover] Fix public(package) causing error when filtering verification target #15854

Closed
wants to merge 1 commit into from

Conversation

rahxephon89
Copy link
Contributor

@rahxephon89 rahxephon89 commented Jan 31, 2025

Description

Filtering of verification target using aptos move prove -f does not work when the target module calls a public(package) function from a callee module because when a filter is applied, only the target module is treated as primary.

This PR tries to resolve the issue by recording all modules that are filtered out when building the model and then allowing the target module to call public(package) functions defined in them.

close #15772.

How Has This Been Tested?

Manually execute aptos move prove -f.

Key Areas to Review

Whether there is a better way to fix the issue more generally.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Move prover

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 31, 2025

⏱️ 6m total CI duration on this PR
Job Cumulative Duration Recent Runs
check-dynamic-deps 3m 🟩
rust-cargo-deny 2m 🟩
general-lints 28s 🟩
semgrep/ci 24s 🟩
file_change_determinator 12s 🟩
permission-check 4s 🟩
permission-check 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@rahxephon89 rahxephon89 force-pushed the teng/fix-public-package-error-in-prover branch from 638d32e to 0c9532c Compare February 12, 2025 20:41
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@rahxephon89 rahxephon89 force-pushed the teng/fix-public-package-error-in-prover branch from 0c9532c to 13017b8 Compare February 12, 2025 23:50
@rahxephon89 rahxephon89 force-pushed the teng/fix-public-package-error-in-prover branch from 13017b8 to 332590a Compare February 12, 2025 23:58
@rahxephon89 rahxephon89 changed the title [WIP][prover] Fix public(package) causing error when filtering verification target [prover] Fix public(package) causing error when filtering verification target Feb 13, 2025
@rahxephon89 rahxephon89 changed the title [prover] Fix public(package) causing error when filtering verification target [Prover] Fix public(package) causing error when filtering verification target Feb 13, 2025
@rahxephon89 rahxephon89 marked this pull request as ready for review February 13, 2025 00:19
@rahxephon89 rahxephon89 requested review from vineethk and wrwg February 13, 2025 00:19
@rahxephon89 rahxephon89 added the stale-exempt Prevents issues from being automatically marked and closed as stale label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][compiler-v2][prover] public(package) error when running aptos move prove -f
1 participant