Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request][CLI] Incorporate multi-architecture CLI Docker image into release pipeline #15878

Open
2 tasks
alnoki opened this issue Feb 4, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@alnoki
Copy link
Contributor

alnoki commented Feb 4, 2025

🚀 Feature Request

@banool @davidiw @gregnazario @sherry-x cc @CRBl69 @xbtmatt

With GitHub actions' new ARM runners, the Aptos CLI can be easily containerized for both AMD and ARM applications, effectively covering almost anyone who needs to develop on a standard PC, regardless of whether it is Linux/Mac/Windows

Motivation

The Aptos CLI is one of the most important tools for SDK, e2e, CI, etc. tests, and compiling it locally or in CI is burdensome due to the excessive number of crate dependencies

Note per X post:

In our case, at least, we need it in Docker so that we can create a localnet with a specific set of Move packages and state already loaded in

Otherwise, running a test would come with minutes of overhead of starting up a localnet, publishing packages, funding accounts, etc.

With Docker we can move all this to build time, and have a derived image with everything ready to go

Pitch

Due to dependencies on the Aptos CLI for our assorted testing, we (Econia Labs) already developed CI to do this but since it is not part of Aptos official tooling, other developers will be less likely to use it: https://github.com/econia-labs/cloud-infra/blob/4ab32d81bc1060295f8ea30b81827426acaa8fe0/src/aptos-cli

  • Incorporate the multi-architecture build process we've developed into official tooling
  • Host on the aptoslabs Docker Hub organization, with new builds any time a CLI release happens
@alnoki alnoki added the enhancement New feature or request label Feb 4, 2025
@alnoki alnoki changed the title [Feature Request][CLI] Create multi-architecture CLI Docker image release pipeline [Feature Request][CLI] Incorporate multi-architecture CLI Docker image into release pipeline Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant