Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make AccountAddress formatting consistent #534

Closed
3 tasks
areshand opened this issue Apr 16, 2022 · 1 comment
Closed
3 tasks

[Feature Request] Make AccountAddress formatting consistent #534

areshand opened this issue Apr 16, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@areshand
Copy link
Contributor

areshand commented Apr 16, 2022

🚀 Feature Request

Motivation

there are a set of methods that convert accountaddress into multiple formats (1) with 0x prefix (2) without 0x prefix (3) without leading 0s. These are not compatible with each other now.
We should either

  1. keep the account address and its string representation consistent,
  2. or provide APIs that is used to read from string or convert account address to string.

Here are some places to be cleaned up.

  • test_from_and_to_account_address
  • remove auth_key from faucet
  • mint param receiver (link), make sure we can have an API to consume both 0x or non 0x for user input.

Pitch

Describe the solution you'd like

Describe alternatives you've considered

Are you willing to open a pull request? (See CONTRIBUTING)

Additional context

@areshand areshand added the enhancement New feature or request label Apr 16, 2022
@gregnazario
Copy link
Contributor

move-language/move#54 to make the 0x inputs more consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants