Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Wrong Hover Animation #1071

Closed
4 of 5 tasks
Rajul-29 opened this issue Jul 14, 2024 · 2 comments · Fixed by #1178
Closed
4 of 5 tasks

[Bug]: Wrong Hover Animation #1071

Rajul-29 opened this issue Jul 14, 2024 · 2 comments · Fixed by #1178
Assignees
Labels
bug Something isn't working gssoc level1

Comments

@Rajul-29
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Hovering on the buttons (Membership, Plan a trip, Book now) on the landing page gives 2 effects at once

Expected behavior

They should show only 1 effect

Add ScreenShots

Screenshot 2024-07-15 045814
Screenshot 2024-07-15 045821

On which device are you experiencing this bug?

Chrome

Record

  • I have read the Contributing Guidelines
  • I'm a GSSOC'24 contributor
  • I'm a VSOC'24 contributor
  • I have starred the repository
@Rajul-29 Rajul-29 added the bug Something isn't working label Jul 14, 2024
@github-actions github-actions bot added the gssoc label Jul 14, 2024
@itsekta
Copy link

itsekta commented Jul 15, 2024

Hey @Rajul-29, nice catch. There is no issues with two animations, but one thing you can do is that move the underline effect just below the text instead of the outside of the buttons and also the color should be similar to the hovering color of the text that is white

@Rajul-29 Rajul-29 mentioned this issue Jul 23, 2024
11 tasks
@Rajul-29
Copy link
Contributor Author

Hey @itsekta
I have made a PR can you look please look into it
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants