Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Improve Adventure Page #1112

Closed
4 of 5 tasks
sau-mili opened this issue Jul 17, 2024 · 11 comments · Fixed by #1121
Closed
4 of 5 tasks

[Feature Request]: Improve Adventure Page #1112

sau-mili opened this issue Jul 17, 2024 · 11 comments · Fixed by #1121
Assignees
Labels
enhancement New feature or request gssoc level2

Comments

@sau-mili
Copy link
Contributor

sau-mili commented Jul 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Feature Description

  • I wish to add filters
  • I wish to add some icons that will show exactly what adventures are available in the place
  • Improve the UI
  • add search bar

Use Case

UI/UX both will be improved this way

Benefits

No response

Add ScreenShots

image

Priority

High

Record

  • I have read the Contributing Guidelines
  • I'm a GSSOC'24 contributor
  • I'm a VSOC'24 contributor
  • I have starred the repository
@sau-mili sau-mili added the enhancement New feature or request label Jul 17, 2024
@github-actions github-actions bot added the gssoc label Jul 17, 2024
@KrishnenduDG
Copy link

@sau-mili Nice feature description. Just if you could clarify about how you are going to manage the filters, I mean the whole procedure of filtering, then I can assign you this issue..

@KrishnenduDG KrishnenduDG added the question Further information is requested label Jul 17, 2024
@sau-mili
Copy link
Contributor Author

I added some icons in the packages.html if you see one of my previous PRs. i want to do similar but this time with adventure sports icons for this page. Also, add a search bar for this

@KrishnenduDG
Copy link

Okk cool... Assigned this issue to you @sau-mili .. Go ahead and make a PR.

@KrishnenduDG KrishnenduDG removed the question Further information is requested label Jul 17, 2024
@sau-mili
Copy link
Contributor Author

@KrishnenduDG can you please check my pull

@itsekta
Copy link

itsekta commented Jul 19, 2024

Hey @sau-mili, can you please add the screenshot by comparing to the current /package url. As i am unable to find any difference

@sau-mili
Copy link
Contributor Author

sure, one sec.

@sau-mili
Copy link
Contributor Author

BEFORE

image

AFTER

Screenshot 2024-07-20 002321
Screenshot 2024-07-20 002334

@sau-mili
Copy link
Contributor Author

Please check @itsekta

@itsekta
Copy link

itsekta commented Jul 20, 2024

Your deployed link
image

Currently deployed
Arpan Codes _ Tourguide - Google Chrome 20-07-2024 12_22_59 PM

@sau-mili
Copy link
Contributor Author

sau-mili commented Jul 20, 2024

https://travel-website-git-patch2-sau-milis-projects.vercel.app?_vercel_share=aIAawH67NKoJXtzKnxvPhLKwhZqCG7tA

What you are showing is package.html, what I am showing is adventure.html

@sau-mili
Copy link
Contributor Author

Currently delployed is
image

Both the screenshot you are showing are my deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants