Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Redirecting links of Services tab is not working, Logo not rendering on website and Light/Dark Mode inconsistency between Book Now page and website. #1629

Closed
5 tasks done
Zubaida0113 opened this issue Nov 5, 2024 · 4 comments · Fixed by #1637
Assignees
Labels
bug Something isn't working gssoc-ext level2

Comments

@Zubaida0113
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Found a few Bugs:-

  1. The logo of the website is not rendering on About Us, Topdeals, Rate Us,
    Screenshot (533)

  2. Mismatch logo on Book now, plan a trip and membership page. Which one is the actual one - the logo with an orange background or the logo with blue earth? Please clarify.Screenshot (523)
    Screenshot (534)

  3. The Services tab section is not being redirected to their respective sub-services(Destinations, trip gallery, hotels and resorts, etc.) only. It is showing not found error because of the wrong file path.
    Screenshot (532)

  4. The light/dark mode of the Book Now page is not synchronized with the website(like if the home page is in dark mode, then the Book Now page remains in light mode). i

  5. This is a feature bug:- The Login and view buttons on the navbar don't have the same design on different subpages. Like on the Home page, it looks like this:-
    Screenshot (534)
    But on other sections like About, packages etc it looks like this:-
    Screenshot (533)

@apu52 So I want to work on the above issue. Please let me know your thoughts on this.

Expected behavior

Here is the expected behaviour for each issue once fixed:

  1. Logo Rendering on Specific Pages: The logo should appear consistently across all pages, including the About Us, Top Deals, and Rate Us pages. The logo should render correctly regardless of the page to provide a uniform look across the website
  2. Logo Mismatch on Certain Pages: Once clarified, either the orange background logo or the blue earth logo should be used consistently across all pages. The logo design should be identical on the Book Now, Plan a Trip, and Membership pages to avoid confusion and reinforce brand identity.
  3. Services Tab Redirection: Each sub-service under the Services tab (such as Destinations, Trip Gallery, and Hotels and Resorts) should redirect to the correct page when clicked. The links should be updated to avoid "Not Found" errors, ensuring a smooth navigation experience for users.
  4. Light/Dark Mode Synchronization: The Book Now page should synchronize its theme with the rest of the website. If the user is in dark mode on any page and navigates to Book Now, it should also display in dark mode, and vice versa. This synchronization should apply globally across all pages.
  5. Navbar Button Design Consistency: The Login and View buttons should have a consistent design on all pages. The styling seen on the Home page should be applied across the About, Packages, and other sections, ensuring uniformity in button appearance across the website.

Add ScreenShots/Videos

No response

On which device are you experiencing this bug?

Android, Chrome, Windows

Record

  • I have read the Contributing Guidelines
  • I'm a GSSOC'24 Extended contributor
  • I'm a Hacktoberfest'24 contributor
  • I have starred the repository
@Zubaida0113 Zubaida0113 added the bug Something isn't working label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

👋 Thanks for opening this issue! We appreciate your contribution. Please make sure you’ve provided all the necessary details and screenshots, and don't forget to follow our Guidelines and Code of Conduct. Happy coding! 🚀

@Zubaida0113
Copy link
Contributor Author

Hey @apu52 there is an issue regarding the label request.
image
Can you check where the issue is? Because I have checked the guidelines for opening an issue, and there doesn't seem to be anything I missed. Did I?

@apu52
Copy link
Owner

apu52 commented Nov 8, 2024

@Zubaida0113 don't worry about the issue labels , I have already given that . this is a very good issue , try to fix it asap

Copy link

✅ This issue has been successfully closed. Thank you for your contribution and helping us improve the project! If you have any more ideas or run into other issues, feel free to open a new one. Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants