Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the needed external dependencies as Git submodules #2

Open
2 of 3 tasks
sisco0 opened this issue Apr 15, 2021 · 2 comments
Open
2 of 3 tasks

Add the needed external dependencies as Git submodules #2

sisco0 opened this issue Apr 15, 2021 · 2 comments

Comments

@sisco0
Copy link
Contributor

sisco0 commented Apr 15, 2021 •
edited
Loading

The needed external dependencies need to be added to the project as Git Submodules. In this way, a complete build could be had by using git clone --recursive command when cloning the AquaMiner GPU repository.

This task should be accomplished after #1.

  • git submodule add each one of the dependencies
  • Test building of the whole project based on the GPU version (no hybrid solution yet in this part).
  • Add Windows capabilities
@sisco0 sisco0 mentioned this issue Apr 15, 2021
Open
3 tasks
@aerth
Copy link
Member

aerth commented Apr 16, 2021

rapidjson dependency is not added , maybe because it is in .gitignore file

@sisco0
Copy link
Contributor Author

sisco0 commented Apr 17, 2021 •
edited
Loading

I agree with @aerth on this point. rapidjson must be deleted from the .gitignore file.

Update
This change has already been solved by ac11cb5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aerth @sisco0