-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download the desired aqua version directly instead of the bootstrap version #716
Comments
That's a good question.
We think Supply Chain Security is so important. To verify checksums, you need to get expected checksums somehow. To solve this issue, we hardcode a specific aqua version and checksums in aqua-installer. That's why the bootstrap is required. Without bootstrap, you need to install one of the following tools before executing aqua-installer, which making aqua-installer hard to use.
And we need to take care of compatibility. For example, users may use old GitHub CLI not supporting gh attestation command. We hardcode versions and checksums of tools which aqua uses internally not to depend on user environment. aqua-installer lets complicated process to Bootstrap causes some overhead, but we accept it. |
I'll add the document. |
@suzuki-shunsuke how about adding the last n versions of aqua's checksums to the installer script? |
In that case, we need to release a new version of aqua-installer every time we release a new version of aqua. Current situation is not so bad, so I don't think we need to improve it so much. |
We don't want to update aqua-installer only for updating checksums frequently because if users use aqua-installer as shell script they need to fix the checksum of aqua-installer when they update aqua-installer, which is bothersome. |
@suzuki-shunsuke there's a tradeoff here - if it's more important for the user to validate the checksum of the aqua-installer they can choose not to update it to the latest version frequently and possibly download aqua twice. |
As I mentioned, we think Supply Chain Security is so important. |
Basically, downloading aqua takes only a few seconds on ubuntu-latest. |
I am talking about the installer script checksum, not the aqua binary checksum. |
Same. We should verify checksum of the installer script in terms of Supply Chain Security. |
The install script currently downloads a bootstrap version of aqua, if a version of aqua is passed to the installer script it then runs
aqua update
which will download aqua again in the desired version.I'm not sure what is the reasoning behind this, but I believe we could download the version that is passed to installer directly.
The text was updated successfully, but these errors were encountered: