Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Indirect Boolean with Enum Field #6092

Closed
knqyf263 opened this issue Feb 9, 2024 Discussed in #5729 · 0 comments · Fixed by #6563
Closed

Replace Indirect Boolean with Enum Field #6092

knqyf263 opened this issue Feb 9, 2024 Discussed in #5729 · 0 comments · Fixed by #6563
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@knqyf263
Copy link
Collaborator

knqyf263 commented Feb 9, 2024

Description

As discussed in the discussion, the current Indirect field is a boolean. This implementation simplifies the representation to either direct or indirect dependencies. However, this binary distinction falls short in scenarios where the dependency type cannot be determined, defaulting to false, which inaccurately represents these cases as direct dependencies.

There are also instances where a dependency does not neatly fit into the direct or indirect categories, such as the root project or in complex structures like multi-module Maven projects. The binary nature of the Indirect field fails to capture these nuances.

To address these limitations, I propose the deprecation of the Indirect boolean field in favor of introducing a new enumeration field, like Relationship, because changing the type of the existing field would be a breaking change. This enum would provide a more nuanced representation of dependency types, including but not limited to direct, indirect, unknown, and potentially more categories to accommodate complex project structures.

This change would enhance the accuracy of dependency representation and provide clearer insights into project dependencies, especially in complex or ambiguous cases.

Discussed in #5729

@knqyf263 knqyf263 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 9, 2024
@knqyf263 knqyf263 added this to the v0.50.0 milestone Feb 9, 2024
@knqyf263 knqyf263 modified the milestones: v0.50.0, v0.51.0 Apr 1, 2024
@knqyf263 knqyf263 self-assigned this Apr 3, 2024
@knqyf263 knqyf263 mentioned this issue Apr 25, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant