Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas cost tests for common utilities, like auth, proxied calls, and permission changes #545

Open
sohkai opened this issue Jul 19, 2019 · 0 comments

Comments

@sohkai
Copy link
Contributor

sohkai commented Jul 19, 2019

Similar to #493, it would be interesting to have explicit gas cost tests on the following common overhead points in an AragonApp:

  • isInitialized modifier vs. without
  • auth modifier vs. without
  • rentrancyGuard modifier vs. without
  • Call through proxy vs. no proxy
  • Cost of an isContract check
  • Cost of initialize() with varying argument sizes
  • Cost of accessing a constant value

And for the ACL:

  • How much it costs to use createPermission() and grantPermission()
@sohkai sohkai changed the title Add gas cost checks for common utilities, like auth, proxied calls, and permission changes Add gas cost tests for common utilities, like auth, proxied calls, and permission changes Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant