-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slogan could be improved #67
Comments
There's not really any room for this, since solidity will complain if you don't format the comments properly. And AFAIK, there's no other comment parsers available out there that a frontend can use to interpolate function calls into a human readable string.
I think you might have misunderstood; it's not an implementation of NatSpec, but piggybacks off of it. |
Maybe "Radspec is a safe parser for Ethereum's NatSpec" or "Radspec is a safe viewer for Ethereum's NatSpec". |
Modified to be "Radspec is a safe interpreter for Ethereum's natspec", although I'd like @onbjerg to chime in if he agrees with this :). |
Radspec and Natspec are not entirely compatible, so I don't think the "slogan" should sort of say that they are |
Can we make them entirely compatible and solve all the problems? |
@onbjerg Isn't Radspec fully compatible with Natspec (although perhaps not the other way around, in the way the interpolation happens in Radspec)? |
From the Ethereum wiki, the natural specification (natspec) of a contract is comprised by all the special comments ( However I think we should go for a friendlier slogan, specially since a lot of developers won't know what natspec is anyway. I think it should mention that radspec produces user interface strings that can take into account call parameters out of comments in the smart contract code. |
It's incompatible because Natspec is just JavaScript. Radspec is not fully compatible with JavaScript. Also Radspec requires type annotations in some situations, Natspec never requires it. I never thought of "Radspec is a safe alternative to Ethereum's natspec" as a slogan, just a short description/introduction 😊 |
Here is a rewrite that bills radspec as THE interpreter for dynamic expressions in NatSpec. I am working on the documentation for NatSpec and it will help if I can just reference the work that is being done here. |
Why solidity documentation references radspec in the natspec documentation if they are not compatible? https://solidity.readthedocs.io/en/v0.5.8/natspec-format.html#dynamic-expressions |
Here is how I documented it:
The discussion of dynamic expressions is entirely outside the scope of Solidity. Solidity does not care what type of expressions you put in there. Now this phrase is confusing: https://github.com/aragon/radspec#aside-why-is-natspec-unsafe
This text inside Radspec is wrong. Nothing is wrong with NatSpec (as has yet been raised). Instead, there are complaints about natspec.js. Radspec should properly refer to NatSpec or natspec.js as appropriate to avoid confusion. |
I see, another question please: How is radspec related to comments written inside solidity code? do you mean that those dynamic expressions are inserted by solidity AS IS into the metadata json and that client side software may use libraries such as radspec to interpret the dynamic expressions inside the natspec comments from the contract metadata json file? |
"Radspec is a safe alternative to Ethereum's natspec"
Reading more it seems like Radspec is a (safe) implementation of NatSpec.
Of course, the last thing we need is fragmentation in the ABI commenting standard.
The text was updated successfully, but these errors were encountered: