Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: @aragon/sdk-client dose not export Erc721TokenDetails #169

Open
pythonpete32 opened this issue Feb 26, 2023 · 1 comment
Open

Bug: @aragon/sdk-client dose not export Erc721TokenDetails #169

pythonpete32 opened this issue Feb 26, 2023 · 1 comment
Labels

Comments

@pythonpete32
Copy link
Contributor

Describe the bug
@aragon/sdk-client exports the Erc20TokenDetails type but not Erc721TokenDetails

To Reproduce (please complete the following information)
import { Erc20TokenDetails, Erc721TokenDetails } from "@aragon/sdk-client";

Expected behavior
to be able to import all the types without redefining them localy

Additional context
Add any other context about the problem here.

pythonpete32 added a commit to pythonpete32/sdk that referenced this issue Feb 26, 2023
@pythonpete32
Copy link
Contributor Author

pythonpete32 commented Mar 27, 2023

adding here as it dosnt make sense to have it as a separate issue

there are a few types missing from the "@aragon/sdk-client"

you have to
import { DepositErc20Params } from "@aragon/sdk-client/dist/interfaces";
as opposed to
import { DepositErc20Params } from "@aragon/sdk-client

  • DepositErc20Params
  • TokenType
  • AssetBalanceSortBy
  • DaoBalancesQueryParams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant