Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpResponse uses json_decode($body, true); - changes data with empty objects #264

Open
MymmiJ opened this issue May 14, 2019 · 0 comments

Comments

@MymmiJ
Copy link

MymmiJ commented May 14, 2019

HttpResponse.php using json_decode($body, true); means that empty objects get translated to arrays, which breaks some of our stuff.

We've extended DocumentHandler in order to override the getDocument method, but I think a better solution might be to provide the ability to decide whether an item is decoded into associative arrays or objects, as this was not obvious default behaviour to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant