Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to turn off "Import" folder creation #101

Open
kkoshel opened this issue Sep 21, 2020 · 2 comments
Open

Ability to turn off "Import" folder creation #101

kkoshel opened this issue Sep 21, 2020 · 2 comments

Comments

@kkoshel
Copy link

kkoshel commented Sep 21, 2020

Installed product versions

  • Visual Studio: 2019 Professional
  • This extension: 1.5

Description

Introduce ability to not create "Import" folder when saving a method to a package on the file system.
As for now when saving a method to a file system I chose AML-package path and internal folders are created for me. There is folder "Import" created that was introduced long time ago because package can contains not only AML files but other (for example some js files that currently are stored in the Innovator\Client\Solutions). So in the past it was reasonable to have this folder. Right now it is not needed and it raise questions for newbies of Innovator "why do we need it?". There is also number of solution without this folder (removed manually, AFAIK).
Still it is addition extra effort that can be annoying to every time move file with method manually.

Can you please create addition checkbox or other configurable approach by using which I can alter folder structure creation logic and omit "Import" folder creation?

Steps to recreate

  1. Open existing method
  2. Try to save it to the AML-package

Current behavior

It is exported to the package with addition intermediate "Import" folder creation.
Example: AML-packages\MyPacakage\Import\Methods\MyMethod.xml

Expected behavior

It should be possible to turn of "Import" folder creation.
Example: AML-packages\MyPacakage\Methods\MyMethod.xml

@EliJDonahue
Copy link
Member

Hi Kirill,

This feature currently follows the behavior of the standard Aras Innovator Export Utility. Core packages are exported without the internal "Import" folder, and all other packages include the "Import" folder when exported.

I'm not sure it's a good idea to implement custom export behavior in the plugin. I think that would cause more confusion and problems than it would solve.

Is there a reason you need to manually remove the Import folder from your packages?

@kkoshel
Copy link
Author

kkoshel commented Sep 24, 2020

Hi Eli,
There was internal discussion on the package naming agreements that also touch this topic:
From one side, yes we aligned with existing behavior in tools and can keep existing structures.
From other side we have a lot of new colleagues that pass on boarding. A lot of them asking why we have such structure and this addition folder. And it is not easy to explain whole historical background of such structure and also it show as as not very flexible in changes. Sooner or later we going to not use such folder (most likely will be supported for backward compatibility).
So as very first step it is suggested to make it optional (but enabled by default).

Same request on functionality will be created for Import/Export tools.

BTW, Do you know if there any addition reasons except historical one to keep such structure?
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants