Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issues with Firefox 52 #1

Open
FlorianCassayre opened this issue Nov 18, 2021 · 4 comments
Open

Compatibility issues with Firefox 52 #1

FlorianCassayre opened this issue Nov 18, 2021 · 4 comments

Comments

@FlorianCassayre
Copy link
Member

Windows XP users are encountering issues with Firefox 52.

A problem with the AbortController prevented the search altogether and was fixed in arbre-app/insee-deces-front@b8d7463.

Now the service appears to work mostly correctly, but there are still some quirks:

  • Dropdowns are not working, clicking on them won't trigger any error but the menu doesn't appear
  • Values in pluralized strings are not injected; normal translated strings do not show any problem

image

@FlorianCassayre
Copy link
Member Author

FlorianCassayre commented Nov 18, 2021

The dropdowns appear to work, up until the permalink button is clicked. At this point no dropdown/popover will ever show up again, until the webpage is refreshed. The DOM still seems to be updated though because I can can briefly see the id attribute of the popover appear when clicked.

@FlorianCassayre
Copy link
Member Author

FlorianCassayre commented Dec 2, 2021

A similar problem (the same?) can also be reproduced on the latest version of Palemoon (reported by Alain A.).

Edit: this problem is reproducible in the development environment.

@FlorianCassayre
Copy link
Member Author

FlorianCassayre commented Dec 2, 2021

The above problem appears to be: react-bootstrap/react-bootstrap#5409
According to thread it is because of React 17, which this project is actually using. The proposed workaround is to add onClick={(e) => e.stopPropagation()} to the triggerer. This effectively fixes the issue with dropdowns/modals/popovers.

FlorianCassayre added a commit to arbre-app/insee-deces-front that referenced this issue Dec 2, 2021
@FlorianCassayre
Copy link
Member Author

FlorianCassayre commented Dec 2, 2021

The patch was deployed and after testing appears indeed to fix the first problem on both Palemoon and Firefox 52.
The only problem remaining is the unparsed pluralized strings (this however is specific to Firefox 52, it does not occur on Palemoon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant