-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instancing 3d nodes off the main thread (in repl) is slow #14
Comments
fixed with 5b46bc4 I'm happy with this hack,: using |
Re-opening this since the NRepl |
To me seems like it's not just slow, but calling instance() from a thread also appears to have stability issues. StringName::operator<(const StringName & p_name) Line 100 (godot\core\string_name.h:100) |
@kdlee ah yeah that's unfortunate, I've heard that instancing in threads will be better supported in Godot 4, but in the mean time if you use the UDP or Socket Repls they will eval on the main thread (https://github.com/arcadia-unity/ArcadiaGodot/blob/master/Source/arcadia/repl.clj#L256) |
looks like this will get fixed with the vulcan renderer: godotengine/godot#36793
Alternately, we could consume REPL forms in the main thread.
The text was updated successfully, but these errors were encountered: