remove dead mock code #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dbutenhof
approved these changes
Sep 9, 2024
webbnh
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
I wouldn't block merging this PR over this, but I'm wondering whether we should be specifically documenting how to generate mocks rather than, say, documenting how to do manual testing in general or providing an automated means to test which would encompass generating the mocks as needed.
webbnh
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
MockContainerEngineClientand its filemocks/mock_ce_client.goare no longer needed because its original source filece_client/ce_client.gowas renamed toce_service/ce_service.go, and that file is covered byMockContainerEngineServiceandmocks/ce_service/ce_service.go.By contributing to this repository, I agree to the contribution guidelines.