Skip to content

Commit

Permalink
add privileged config option (#58)
Browse files Browse the repository at this point in the history
* add privileged config option

* add privileged to argsbuilder and deploy

* explicitly set default value as false
  • Loading branch information
mfleader authored Apr 22, 2024
1 parent a2894f9 commit 9d1fe15
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 1 deletion.
3 changes: 2 additions & 1 deletion connector.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ func (c *Connector) Deploy(ctx context.Context, image string) (deployer.Plugin,
SetEnv(containerConfig.Env).
SetVolumes(hostConfig.Binds).
SetCgroupNs(string(hostConfig.CgroupnsMode)).
SetNetworkMode(string(hostConfig.NetworkMode))
SetNetworkMode(string(hostConfig.NetworkMode)).
SetPrivileged(hostConfig.Privileged)

stdin, stdout, err := c.podmanCliWrapper.Deploy(image, commandArgs, []string{"--atp"})

Expand Down
7 changes: 7 additions & 0 deletions internal/argsbuilder/argsbuilder.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,10 @@ func (a *argsBuilder) SetNetworkMode(networkMode string) ArgsBuilder {
}
return a
}

func (a *argsBuilder) SetPrivileged(privileged bool) ArgsBuilder {
if privileged {
*a.commandArgs = append(*a.commandArgs, "--privileged")
}
return a
}
1 change: 1 addition & 0 deletions internal/argsbuilder/argsbuilder_interface.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ type ArgsBuilder interface {
SetCgroupNs(cgroupNs string) ArgsBuilder
SetContainerName(name string) ArgsBuilder
SetNetworkMode(networkMode string) ArgsBuilder
SetPrivileged(privileged bool) ArgsBuilder
}

func NewBuilder(commandArgs *[]string) ArgsBuilder {
Expand Down
10 changes: 10 additions & 0 deletions schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,16 @@ var Schema = schema.NewTypedScopeSchema[*Config](
nil,
nil,
).Disable(notImplemented),
"Privileged": schema.NewPropertySchema(
schema.NewBoolSchema(),
schema.NewDisplayValue(schema.PointerTo("Privileged"), schema.PointerTo("Execute container process without security features that isolate the container from the host"), nil),
false,
nil,
nil,
nil,
schema.PointerTo(util.JSONEncode(false)),
nil,
),
},
),
schema.NewStructMappedObjectSchema[*nat.PortBinding](
Expand Down

0 comments on commit 9d1fe15

Please sign in to comment.