From b45b88047200b85301cf32f342e7a468a076d2a6 Mon Sep 17 00:00:00 2001
From: Dustin Black <dblack@redhat.com>
Date: Fri, 15 Dec 2023 12:11:08 +0100
Subject: [PATCH] ensure lists are converted to Opensearch-compatible formats

---
 .../opensearch_plugin.py                      | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/arcaflow_plugin_opensearch/opensearch_plugin.py b/arcaflow_plugin_opensearch/opensearch_plugin.py
index 19d2ddd..f6578dd 100644
--- a/arcaflow_plugin_opensearch/opensearch_plugin.py
+++ b/arcaflow_plugin_opensearch/opensearch_plugin.py
@@ -9,6 +9,46 @@
 from opensearch_schema import ErrorOutput, SuccessOutput, StoreDocumentRequest
 
 
+def convert_to_supported_type(value) -> typing.Dict:
+    type_of_val = type(value)
+    if type_of_val == list:
+        new_list = []
+        for i in value:
+            new_list.append(convert_to_supported_type(i))
+        # A list needs to be of a consistent type or it will
+        # not be indexible into a system like Opensearch
+        return convert_to_homogenous_list(new_list)
+    elif type_of_val == dict:
+        result = {}
+        for k in value:
+            result[convert_to_supported_type(k)] = convert_to_supported_type(
+                value[k]
+            )
+        return result
+    elif type_of_val in (float, int, str, bool):
+        return value
+    elif isinstance(type_of_val, type(None)):
+        return str("")
+    else:
+        print("Unknown type", type_of_val, "with val", str(value))
+        return str(value)
+
+def convert_to_homogenous_list(input_list: list):
+    # To make all types in list homogeneous, we upconvert them
+    # to the least commom type.
+    # int -> float -> str
+    # bool + None -> str
+    list_type = str()
+    for j in input_list:
+        if type(j) in (str, bool, type(None)):
+            list_type = str()
+            break
+        elif type(j) is float:
+            list_type = float()
+        elif type(j) is int and type(list_type) is not float:
+            list_type = int()
+    return list(map(type(list_type), input_list))
+
 @plugin.step(
     id="opensearch",
     name="OpenSearch",
@@ -18,6 +58,8 @@
 def store(
     params: StoreDocumentRequest,
 ) -> typing.Tuple[str, typing.Union[SuccessOutput, ErrorOutput]]:
+    document = convert_to_supported_type(params.data)
+
     try:
         if params.username:
             opensearch = OpenSearch(
@@ -31,7 +73,10 @@ def store(
                 hosts=params.url,
                 verify_certs=params.tls_verify,
             )
-        resp = opensearch.index(index=params.index, body=params.data)
+        resp = opensearch.index(
+            index=params.index,
+            body=document,
+        )
         if resp["result"] != "created":
             raise Exception(f"Document status: {resp['_shards']}")