Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage output should be omitted from the final container image #71

Open
webbnh opened this issue Feb 13, 2024 · 0 comments
Open

Comments

@webbnh
Copy link
Contributor

webbnh commented Feb 13, 2024

Dustin and I did a little investigation: the coverage file is generated in the first phase of the container build; it is propagated to the final container image; the CI later pulls the image from Quay, creates a container from it (but doesn't start it running), pulls coverage file from it, and then deletes the container; the CI then processes and uploads the coverage data as an artifact so that it can be viewed later.

Thus, there is no compelling need for the coverage file to be in the final container image, other than as a mechanism for making it available to CI; and, the desire to minimize the size of the container image is motivation for not including it in the final image.

Instead, the initial build phase should export the coverage file (either by writing it to a mapped directory, or by having the CI extract it after the image is built, as it does with the final image, today), so that we don't propagate it to the final image. The CI can then process and upload the artifact.

Originally posted by @webbnh in arcalot/arcaflow-plugin-pcp#34 ("conversations" link, "files" link)

@webbnh webbnh changed the title Dustin and I did a little investigation: the coverage file is generated in the first phase of the container build; it is propagated to the final container image; the CI later pulls the image from Quay, creates a container from it (but doesn't start it running), pulls coverage file from it, and then deletes the container; the CI then processes and uploads the coverage data as an artifact so that it can be viewed later. Test coverage output should be omitted from the final container image Feb 13, 2024
@dustinblack dustinblack transferred this issue from arcalot/arcaflow-plugin-pcp Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant