You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Dustin and I did a little investigation: the coverage file is generated in the first phase of the container build; it is propagated to the final container image; the CI later pulls the image from Quay, creates a container from it (but doesn't start it running), pulls coverage file from it, and then deletes the container; the CI then processes and uploads the coverage data as an artifact so that it can be viewed later.
Thus, there is no compelling need for the coverage file to be in the final container image, other than as a mechanism for making it available to CI; and, the desire to minimize the size of the container image is motivation for not including it in the final image.
Instead, the initial build phase should export the coverage file (either by writing it to a mapped directory, or by having the CI extract it after the image is built, as it does with the final image, today), so that we don't propagate it to the final image. The CI can then process and upload the artifact.
The text was updated successfully, but these errors were encountered:
webbnh
changed the title
Dustin and I did a little investigation: the coverage file is generated in the first phase of the container build; it is propagated to the final container image; the CI later pulls the image from Quay, creates a container from it (but doesn't start it running), pulls coverage file from it, and then deletes the container; the CI then processes and uploads the coverage data as an artifact so that it can be viewed later.
Test coverage output should be omitted from the final container image
Feb 13, 2024
Dustin and I did a little investigation: the coverage file is generated in the first phase of the container build; it is propagated to the final container image; the CI later pulls the image from Quay, creates a container from it (but doesn't start it running), pulls coverage file from it, and then deletes the container; the CI then processes and uploads the coverage data as an artifact so that it can be viewed later.
Thus, there is no compelling need for the coverage file to be in the final container image, other than as a mechanism for making it available to CI; and, the desire to minimize the size of the container image is motivation for not including it in the final image.
Instead, the initial build phase should export the coverage file (either by writing it to a mapped directory, or by having the CI extract it after the image is built, as it does with the final image, today), so that we don't propagate it to the final image. The CI can then process and upload the artifact.
Originally posted by @webbnh in arcalot/arcaflow-plugin-pcp#34 ("conversations" link, "files" link)
The text was updated successfully, but these errors were encountered: