Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fabric 5.0 #48

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

marcohamersma
Copy link

Here's some fixes to support Fabric 5.0, based on some of the issues in #43.

It:

  1. moves fabric to a peerDependency
  2. allows v5 as a dependency version (I haven't done this before, so if there's a better way to do this feel free to fix)
  3. passes along context to setBrushStyles. This should not have any effect for people on Fabric v4

Additionally, I removed sharp as a dependency for two reasons:

  1. it seemed like it wasn't used directly.
  2. I ran into issues while running npm install while it was still in the dependencies.

I could not recreate the brush color issue I mentioned in #43. Not sure what was up.

Feel free to comment or make any changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant