New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of 'permit' for approvals #59

Open

chpiatt opened this issue May 26, 2021 · 0 comments

Contributor

chpiatt commented May 26, 2021 •

edited

Loading

The Uni v3 frontend has added basic support for tokens that use permit for approvals, see:
https://github.com/Uniswap/uniswap-interface/blob/main/src/hooks/useERC20Permit.ts

Archerswap router also includes support for 'permit' for each of the swap functions, see:

archerswap/packages/smart-contracts/contracts/ArcherSwapRouter.sol

Line 312 in 13d1e9d

function swapExactTokensForETHWithPermitAndTipAmount(

We should add support for the same permit flow used in the Uniswap V3 interface.

To begin with, we can just support the same PERMITTABLE_TOKENS that Uni V3 is supporting + ARCH (ARCH uses PermitType.AMOUNT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment