Remove some non-null assertions

archesproject · Aug 6, 2024 · f77cc1d · f77cc1d
1 parent 351c248
commit f77cc1d
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 18 deletions.
diff --git a/arches_references/src/arches_references/components/editor/ImageMetadata.vue b/arches_references/src/arches_references/components/editor/ImageMetadata.vue
@@ -122,7 +122,7 @@ const issueDeleteMetadata = async (
 };
 
 const appendImageMetadata = (newMetadata: ControlledListItemImageMetadata) => {
-    const imageFromItem = item.value!.images.find(
+    const imageFromItem = item.value.images.find(
         (imageCandidateFromItem) =>
             imageCandidateFromItem.id === newMetadata.list_item_image_id,
     );
@@ -134,7 +134,7 @@ const appendImageMetadata = (newMetadata: ControlledListItemImageMetadata) => {
 const removeImageMetadata = (
     removedMetadata: NewOrExistingControlledListItemImageMetadata,
 ) => {
-    const imageFromItem = item.value!.images.find(
+    const imageFromItem = item.value.images.find(
         (imageCandidateFromItem) =>
             imageCandidateFromItem.id === removedMetadata.list_item_image_id,
     );
@@ -152,7 +152,7 @@ const removeImageMetadata = (
 const updateImageMetadata = (
     updatedMetadata: ControlledListItemImageMetadata,
 ) => {
-    const imageFromItem = item.value!.images.find(
+    const imageFromItem = item.value.images.find(
         (imageCandidateFromItem) =>
             imageCandidateFromItem.id === updatedMetadata.list_item_image_id,
     );
@@ -185,10 +185,10 @@ const issueDeleteImage = async () => {
 };
 
 const removeImage = (removedImage: ControlledListItemImage) => {
-    const toDelete = item.value!.images.findIndex(
+    const toDelete = item.value.images.findIndex(
         (imageFromItem) => imageFromItem.id === removedImage.id,
     );
-    item.value!.images.splice(toDelete, 1);
+    item.value.images.splice(toDelete, 1);
 };
 
 const makeMetadataEditable = (

diff --git a/arches_references/src/arches_references/components/editor/ItemImages.vue b/arches_references/src/arches_references/components/editor/ItemImages.vue
@@ -34,7 +34,7 @@ const addHeader = (event: FileUploadBeforeSendEvent) => {
     const token = Cookies.get("csrftoken");
     if (token) {
         event.xhr.setRequestHeader("X-CSRFToken", token);
-        event.formData.set("list_item_id", item.value!.id);
+        event.formData.set("list_item_id", item.value.id);
     }
 };
 
@@ -44,7 +44,7 @@ const upload = (event: FileUploadUploadEvent) => {
         return;
     }
     const newImage = JSON.parse(event.xhr.responseText);
-    item.value!.images.push(newImage);
+    item.value.images.push(newImage);
 };
 
 const showError = (event?: FileUploadErrorEvent | FileUploadUploadEvent) => {

diff --git a/arches_references/src/arches_references/components/editor/ListCharacteristic.vue b/arches_references/src/arches_references/components/editor/ListCharacteristic.vue
@@ -35,7 +35,7 @@ const field = "name";
 
 const inputValue = computed({
     get() {
-        return list.value!.name;
+        return list.value.name;
     },
     set(newVal: string) {
         formValue.value = newVal;
@@ -47,8 +47,8 @@ const { $gettext } = useGettext();
 
 const save = async () => {
     editing.value = false;
-    const originalValue = list.value!.name;
-    list.value!.name = formValue.value.trim();
+    const originalValue = list.value.name;
+    list.value.name = formValue.value.trim();
     try {
         await patchList(list.value!, field);
     } catch (error) {
@@ -58,13 +58,13 @@ const save = async () => {
             summary: $gettext("Save failed"),
             detail: error instanceof Error ? error.message : undefined,
         });
-        list.value!.name = originalValue;
+        list.value.name = originalValue;
     }
 };
 
 const cancel = () => {
     editing.value = false;
-    formValue.value = list.value!.name;
+    formValue.value = list.value.name;
 };
 </script>
 

diff --git a/arches_references/src/arches_references/components/tree/MoveRow.vue b/arches_references/src/arches_references/components/tree/MoveRow.vue
@@ -80,8 +80,8 @@ watch(displayedRow, () => {
 
 const isFirstItem = (item: ControlledListItem) => {
     const siblings: TreeNode[] = item.parent_id
-        ? findNodeInTree(tree.value, item.parent_id).data!.children
-        : findNodeInTree(tree.value, item.list_id).data!.items;
+        ? findNodeInTree(tree.value, item.parent_id).data.children
+        : findNodeInTree(tree.value, item.list_id).data.items;
     if (!siblings.length) {
         throw new Error();
     }

diff --git a/arches_references/src/arches_references/components/tree/TreeRow.vue b/arches_references/src/arches_references/components/tree/TreeRow.vue
@@ -98,7 +98,7 @@ const rowLabel = computed(() => {
     }
     const unstyledLabel =
         node.data.name ??
-        bestLabel(node.data, selectedLanguage!.value.code).value;
+        bestLabel(node.data, selectedLanguage.value.code).value;
     if (!filterValue.value) {
         return unstyledLabel;
     }
@@ -213,7 +213,7 @@ const acceptNewItemShortcutEntry = async () => {
     );
     parent.children = [
         ...parent.children!.filter((child: TreeNode) => !dataIsNew(child.data)),
-        itemAsNode(newItem, selectedLanguage!.value),
+        itemAsNode(newItem, selectedLanguage.value),
     ];
     if (nodeIsList(parent)) {
         parent.data.items.push(newItem);
@@ -252,7 +252,7 @@ const acceptNewListShortcutEntry = async () => {
     }
     tree.value = [
         ...tree.value.filter((cList) => !dataIsNew(cList.data)),
-        listAsNode(newList, selectedLanguage!.value),
+        listAsNode(newList, selectedLanguage.value),
     ];
     selectedKeys.value = { [newList.id]: true };
     setDisplayedRow(newList);
@@ -308,7 +308,7 @@ const acceptNewListShortcutEntry = async () => {
                         {
                             item: bestLabel(
                                 movingItem.data,
-                                selectedLanguage!.code,
+                                selectedLanguage.code,
                             ).value,
                         },
                         true,