Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Notifier to Handle GeoPatch Changes #1619

Open
wassimans opened this issue Dec 2, 2024 · 0 comments · May be fixed by #1620
Open

Enhance Notifier to Handle GeoPatch Changes #1619

wassimans opened this issue Dec 2, 2024 · 0 comments · May be fixed by #1620
Assignees
Labels
election enhancements P2P Involve P2P networking

Comments

@wassimans
Copy link
Contributor

wassimans commented Dec 2, 2024

Is your feature request related to a problem?

The Notifier module is responsible for handling topology changes and ensuring data replication across the correct storage nodes. Currently, it compares the set of prev_available_nodes, new_available_nodes, and unavailable_nodes to determine how the topology should change. However, this logic is outdated, as the Notifier no longer needs to explicitly consider unavailable_nodes.

Additionally, the Notifier does not handle scenarios where a node’s GeoPatch changes. A GeoPatch update impacts the election of storage nodes and validation nodes, requiring the network to reorganize data responsibilities. Without support for GeoPatch updates, storage elections and data distribution may become inconsistent.

Describe the solution you’d like

We need to refactor the Notifier module with the following changes:

  1. Refactor Notifier Logic: Removing the dependency on unavailable_nodes in election and topology change calculations. Focusing exclusively on prev_available_nodes and new_available_nodes to simplify the logic and reflect current system needs.

  2. Enhancing GeoPatch Handling to update the P2P context: by using the Notifier to systematically update storage nodes’ responsibilities and trigger data replication for impacted transactions whenever a node transaction with GeoPatch update is validated.

Additional context

Epic

@wassimans wassimans added election enhancements P2P Involve P2P networking labels Dec 2, 2024
@wassimans wassimans added this to the BLS prerequisites milestone Dec 2, 2024
@wassimans wassimans self-assigned this Dec 2, 2024
@wassimans wassimans linked a pull request Dec 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
election enhancements P2P Involve P2P networking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant