Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This mod should be Nether-aware. #1

Open
Deathwing777 opened this issue Feb 20, 2024 · 0 comments
Open

This mod should be Nether-aware. #1

Deathwing777 opened this issue Feb 20, 2024 · 0 comments

Comments

@Deathwing777
Copy link

Deathwing777 commented Feb 20, 2024

Hi, I ran into an issue when using this mod in conjunction with Hybrid Dog's Nether mod. The Shadow Realm 1 HP/sec when below y=-200 makes the Nether completely unplayable and traps players in an endless death cycle with no hope of escape. I have added a global table NETHER with a function NETHER["is_player_in_nether"](player) to the Nether mod, and a simple test in the Shadow Realms realm.lua script disables the 1 HP/sec. For completeness, I added a check for the NETHER global table, and use the result of that to instantiate a local function which will either just return false (if no nether mod is installed) or call the nether mod function to test player state. I also added "nether" to optional_depends in the Shadow Realm mod.conf.

realm.lua.txt
mod.conf.txt

It would be nice to have some configurable options (possibly via fmod), so we could change the y level at which the 1 HP/sec damage starts to happen. I may do that next, and kick it back up to you.

Deathwing777 added a commit to Deathwing777/shadowrealm that referenced this issue Feb 20, 2024
This fixes Issue 1 "This mod should be Nether-aware. archfan7411#1" with the upstream codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant