Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write script to detect curly quotes and other QA peace of mind #44

Open
elotroalex opened this issue Nov 28, 2020 · 7 comments
Open

Write script to detect curly quotes and other QA peace of mind #44

elotroalex opened this issue Nov 28, 2020 · 7 comments

Comments

@elotroalex
Copy link
Contributor

No description provided.

@Denubis
Copy link
Collaborator

Denubis commented Dec 4, 2020

You reintroduced smartquotes!!!!

Don't use smartquotes! If you want nested quotes, use single and double quotes. Aborting.
./josephs-blogging.md:19: ```

Will fix, but grr

@elotroalex
Copy link
Contributor Author

i thought we had taken them out completely. i did not consciously do this. something smells fishy here. i'll investigate

@Denubis
Copy link
Collaborator

Denubis commented Dec 4, 2020

Ok, on rebuild I'm going to add this QA stuff as a precommit hook. Let's figure out what automated QA we want. I've been doing a lot recently with automated github actions (i.e. autocompile of CV: https://github.com/Denubis/Academic-LaTeX-CV-BibTeX-CSV -- so let's start getting a wishlist of autodeploy stuffs together

@Denubis
Copy link
Collaborator

Denubis commented Dec 4, 2020

Nah, not accusing you. Word is evil.

@elotroalex
Copy link
Contributor Author

i kinda like one that detects all of the curly quotes on all files in the issues. that's one for sure. another could be missing images because wrong filename and what not. i'll think of more.

@elotroalex
Copy link
Contributor Author

we could for all intentst and purposes make the action so that it goes ahead and replaces the curlies right away. with some testing we could figure out when those auto replaces would break things.

@Denubis
Copy link
Collaborator

Denubis commented Dec 4, 2020

Yep. Automate the tedious stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants