From ea3d34b6c51a59cb77d350f9d63525907a880696 Mon Sep 17 00:00:00 2001 From: Juuz <6596629+Juuxel@users.noreply.github.com> Date: Sat, 7 Dec 2024 00:08:13 +0200 Subject: [PATCH] RemapJarTask: Support config cache for Aw2At --- .../loom/extensions/ModBuildExtensions.java | 9 ++------- .../java/net/fabricmc/loom/task/RemapJarTask.java | 13 +++++++------ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/src/main/java/dev/architectury/loom/extensions/ModBuildExtensions.java b/src/main/java/dev/architectury/loom/extensions/ModBuildExtensions.java index f40fc64c5..bdfccfe0a 100644 --- a/src/main/java/dev/architectury/loom/extensions/ModBuildExtensions.java +++ b/src/main/java/dev/architectury/loom/extensions/ModBuildExtensions.java @@ -19,6 +19,7 @@ import dev.architectury.at.AccessTransformSet; import dev.architectury.at.io.AccessTransformFormats; import org.gradle.api.provider.Property; +import org.gradle.api.provider.Provider; import org.gradle.api.provider.SetProperty; import org.jetbrains.annotations.Nullable; @@ -49,13 +50,7 @@ public static Set readMixinConfigsFromManifest(File jarFile) { } } - public static void convertAwToAt(ServiceFactory serviceFactory, SetProperty atAccessWidenersProperty, Path outputFile, Property options) throws IOException { - if (!atAccessWidenersProperty.isPresent()) { - return; - } - - Set atAccessWideners = atAccessWidenersProperty.get(); - + public static void convertAwToAt(ServiceFactory serviceFactory, Set atAccessWideners, Path outputFile, Provider options) throws IOException { if (atAccessWideners.isEmpty()) { return; } diff --git a/src/main/java/net/fabricmc/loom/task/RemapJarTask.java b/src/main/java/net/fabricmc/loom/task/RemapJarTask.java index 91a22ffc1..b8dd8c5a1 100644 --- a/src/main/java/net/fabricmc/loom/task/RemapJarTask.java +++ b/src/main/java/net/fabricmc/loom/task/RemapJarTask.java @@ -212,10 +212,6 @@ public void run() { params.getReadMixinConfigsFromManifest().set(getReadMixinConfigsFromManifest()); params.getAtAccessWideners().set(getAtAccessWideners()); - if (!getAtAccessWideners().get().isEmpty()) { - params.getMappingsServiceOptions().set(MappingsService.createOptionsWithProjectMappings(getProject(), getSourceNamespace(), getTargetNamespace())); - } - params.getOptimizeFmj().set(getOptimizeFabricModJson().get()); }); } @@ -236,7 +232,6 @@ public interface RemapParams extends AbstractRemapParams { Property getTinyRemapperServiceOptions(); ListProperty getMixinRefmapServiceOptions(); - Property getMappingsServiceOptions(); } public abstract static class RemapAction extends AbstractRemapAction { @@ -277,7 +272,13 @@ public void execute() { addRefmaps(serviceFactory); addNestedJars(); - ModBuildExtensions.convertAwToAt(serviceFactory, getParameters().getAtAccessWideners(), outputFile, getParameters().getMappingsServiceOptions()); + + if (getParameters().getAtAccessWideners().isPresent()) { + final Provider mappingsServiceOptions = getParameters().getTinyRemapperServiceOptions() + .flatMap(TinyRemapperService.Options::getMappings) + .map(mappingsOptions -> mappingsOptions.get(0)); + ModBuildExtensions.convertAwToAt(serviceFactory, getParameters().getAtAccessWideners().get(), outputFile, mappingsServiceOptions); + } if (!getParameters().getPlatform().get().isForgeLike()) { modifyJarManifest();