Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Identity/Auth to template #300

Open
ardalis opened this issue Dec 17, 2021 · 11 comments
Open

Add Identity/Auth to template #300

ardalis opened this issue Dec 17, 2021 · 11 comments
Assignees

Comments

@ardalis
Copy link
Owner

ardalis commented Dec 17, 2021

The default template should support default Identity.

I don't recommend having both cookie- and token-based auth in the same project, so I will probably start with just token support.

@ahmedanwar100
Copy link

I want to work on it, please assign it to me

@ardalis
Copy link
Owner Author

ardalis commented Oct 21, 2022

All yours. Realize that we are making some substantial changes for .NET 7. Go ahead and add JWT token auth to the current main branch (net6) version and we can hold off on adding it to the net7 version until after net7 ships.

@ahmedanwar100
Copy link

@ardalis can you please review it
Add Identity/Auth to template #300

@FlorianHoornaar
Copy link

@ahmedanwar100 I reviewed your PR. It looks good and I would like to incorporate it in the solution I am developing. Would you be willing to help me do that. I'd be happy to compensate you for your time and effort.

@ahmedanwar100
Copy link

sure @FlorianHoornaar

@ardalis
Copy link
Owner Author

ardalis commented Apr 10, 2023

@ahmedanwar100 can you resolve the conflicts now that we're on net7 and I'll try to merge this in this week?

@ahmedanwar100
Copy link

ahmedanwar100 commented Apr 10, 2023 via email

@DerekChasse
Copy link

I've looked at the pull request and seen comments from @ardalis which suggested moving the customer IdentityUser and IdentityRole implementations from Core to Infrastructure. I don't disagree with this, but if I wanted to fire Domain Events when a new user is created or logs in... where would those events live? Do they belong in Core? In Infrastructure?

Is the Infrastructure project the correct place for a UserAggregate folder similarly to the ProjectAggregate folder in core?

@ahmedanwar100
Copy link

@ardalis can you please clear it out and please take a look at the PR so it can be merged
Thanks

@raihanmehran
Copy link

@DerekChasse @ardalis
Is this feature added or can I work on this?

@ahmedanwar100
Copy link

This feature is already implemented, just a review from @ardalis is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants