SimpleModelService.getAllTemplate (sic) is a bit wut

[romdoq]

Granted I'm no Java expert, but in addition to the method name not being plural, I think this function logic might need a second look:

ardoq-java-client/src/main/java/com/ardoq/service/SimpleModelService.java

Lines 34 to 47 in 03731c3

	public List<Model> getAllTemplate(boolean includeCommon) {
	List<Model> allModels = modelService.getAllModelsIncludingCommonTemplate();
	ArrayList<Model> templates = new ArrayList<Model>();
	for (Model model : allModels) {
	if (model.isTemplate()) {
	if (!includeCommon && !model.isTemplate()) {
	templates.add(model);
	} else {
	templates.add(model);
	}
	}
	}
	return templates;
	}