Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

#define probable name collision in CAT9555.h #8

Open
AlexanderBrevig opened this issue Apr 28, 2016 · 0 comments
Open

#define probable name collision in CAT9555.h #8

AlexanderBrevig opened this issue Apr 28, 2016 · 0 comments

Comments

@AlexanderBrevig
Copy link

https://github.com/arduino-org/arduino-library-lucky-shield/blob/master/src/lib/CAT9555.h#L47

We should discourage the use of #defines as the compiler will do an excellent job of optimizing constants too and then they're scoped correctly :)

If the pins are tightly (wired) bound to a function then maybe the whole gpio() thing is a fallacy and we should expose a method per pin function?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant