Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getFormattedDate() in 3.1.0 no longer in latest3.2.1 #183

Closed
MarcEngrie opened this issue Nov 29, 2022 · 1 comment
Closed

getFormattedDate() in 3.1.0 no longer in latest3.2.1 #183

MarcEngrie opened this issue Nov 29, 2022 · 1 comment
Assignees
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@MarcEngrie
Copy link

Hi,

I went through an upgrade cycle where I also upgraded this library from 3.1.0 to the latest 3.2.1. Now, all my previous apps (all of them use the NTPClient), fail to compile as the function getFormattedDate() is no longer present in the library.

Any reason why and what your suggestted alternative is?

@per1234
Copy link
Contributor

per1234 commented Nov 29, 2022

Hi @MarcEngrie. Thanks for your report. There has never been a function of this name in the official library:

https://github.com/arduino-libraries/NTPClient/blob/3.1.0/NTPClient.h

I think you must have previously installed the development version of the library from this pull request, which does add a function of that name: #119

@per1234 per1234 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
@per1234 per1234 self-assigned this Nov 29, 2022
@per1234 per1234 added type: imperfection Perceived defect in any part of project conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself labels Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

2 participants