Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variant/mkrnb1500 SARA R410 UART not configured to utilize flow control (RTS/CTS) #689

Open
ardiri opened this issue Dec 25, 2022 · 0 comments

Comments

@ardiri
Copy link

ardiri commented Dec 25, 2022

the schematic of the MKRNB1500 includes support for flow control (RTS/CTS) between the samd21 and the ublox SARA r410 modem.

Screen Shot 2022-12-22 at 08 02 19

when looking at the implementation; the Serial UART fails to include the flow control lines, when the GSM 1400 does

variant/mkrnb1500/variant.cpp
// SerialSARA
Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);

void SERCOM4_Handler()
{
  Serial2.IrqHandler();
}

variant/mkrgsm1400/variant.cpp
// SerialGSM
Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);

void SERCOM4_Handler()
{
  Serial2.IrqHandler();
}

to enable flow-control; the SerialSARA (Serial2) definition simply needs to be updated:

variant/mkrnb1500/variant.cpp
// SerialSARA
- Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX);
+ Uart Serial2(&sercom4, PIN_SERIAL2_RX, PIN_SERIAL2_TX, PAD_SERIAL2_RX, PAD_SERIAL2_TX, PIN_SERIAL2_RTS, PIN_SERIAL2_CTS);

void SERCOM4_Handler()
{
  Serial2.IrqHandler();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant