What should be checked in with a Pull Requesta?

[KurtE]

@pillo79 @facchinm ... @mjs513

I just replaced the two previous PRs associated with the Portenta H7 with a new one,

But I am wondering what your preferences are for what files should be checked in as part of the PR?

Obviously, the source files that we changed as part of the PR.

But for example with PR #85 I would see @pillo79 checked in everything that changed after you would
do a build_all.sh? Which I did this time as part of #87. But wondering if that is the desired way?

The benefit of this was I could simply sync up and try doing a burn bootloader and then program a sketch
without having to build.

Probably downside, is if you have multiple PRs that you are trying to pull in, you will probably see conflicts with all of the
generated files.

Alternatively, one could just check in the files associated with doing a build of only those boards that
are affected.

Best to ask here? Or the forum?

Thoughts?

[facchinm]

We are thinking about an alternative method to ship artifacts that will likely resolve the confusion with mass rebuilds.
The idea is to use the CI to produce the llext-edk and firmware for a given commit (as it already does), remove the files from the repo and provide a script to retrieve the correct artifacts in case you want to develop/fix only the arduino part.
It would work like this:

• a contributor that wants to rebuild the loader (eg. to integrate new functionality) will keep running bootstrap and then build_all to recreate the files
• a contributor that wants to submit a fix to the arduino part of the core (libraries too) can test its contribution by cloning in $skecthbook/hardware and running this sync script before submitting the PR

Hope this will ease the whole process 🙂

[KurtE]

Thanks @facchinm, I was wondering if you might go down that path.