Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DShot library for RP2040 #6081

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add DShot library for RP2040 #6081

merged 1 commit into from
Mar 21, 2025

Conversation

bastian2001
Copy link
Contributor

Bidirectional DShot support for RP2040/RP2350

@github-actions github-actions bot added the topic: submission Add library to the list label Mar 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/bastian2001/pico-bidir-dshot:

Linting library in pico-bidir-dshot
INFO: No header file found matching library name (DShot_for_RP2040_RP235x__Pi_Pico_.h). Best practices are for primary  
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value DShot for RP2040/RP235x (Pi Pico) is longer than the recommended length of 32    
         characters.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP010)                                                                                                   
ERROR: Prohibited character(s) in library.properties name value: DShot for RP2040/RP235x (Pi Pico)           
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name DShot for RP2040/RP235x (Pi Pico) contains spaces. Although supported, best practices  
         is to not use spaces.                                                                                          
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in pico-bidir-dshot/examples/0_BareMinimum_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/0_BareMinimum_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/1_Blink_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/1_Blink_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/2_Playground_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/2_Playground_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/3_Special_Cmd_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/3_Special_Cmd_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/4_Full_Pro_Bidir

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @bastian2001
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@bastian2001
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/bastian2001/pico-bidir-dshot:

Linting library in pico-bidir-dshot
INFO: No header file found matching library name (DShot_for_RP2040_RP2350_Pi_Pico.h). Best practices are for primary    
      header filename to match library name.                                                                            
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: DShot_for_RP2040/RP2350_Pi_Pico             
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in pico-bidir-dshot/examples/0_BareMinimum_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/0_BareMinimum_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/1_Blink_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/1_Blink_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/2_Playground_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/2_Playground_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/3_Special_Cmd_Bidir

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/3_Special_Cmd_normal

Linter results for project: no errors or warnings

-------------------

Linting sketch in pico-bidir-dshot/examples/4_Full_Pro_Bidir

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 0 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @bastian2001
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@bastian2001
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot merged commit 98454fa into arduino:main Mar 21, 2025
14 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/bastian2001/pico-bidir-dshot/

github-actions bot pushed a commit that referenced this pull request Mar 21, 2025
@ArduinoBot
Add submission # 6081
250252c 
#6081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bastian2001