Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support meta config #51

Open
argonui opened this issue Nov 23, 2022 · 2 comments
Open

Support meta config #51

argonui opened this issue Nov 23, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@argonui
Copy link
Owner

argonui commented Nov 23, 2022

If there was such a file as TTSModManager.config, then it could allow for setting more options and flag than makes sense to have on the commandline.

Some ideas:

  • paths to ... (instead of current default)
    • lua src ($moddir/src)
    • xml src ($moddir/xml)
    • root config ($moddir/config.json)
  • write to src when decomposing?
  • set $moddir instead of passing each time
  • set $modfile instead of passing each time

Please comment with other ideas and what use cases this would enable

@argonui argonui added the enhancement New feature or request label Nov 23, 2022
@rolandostar
Copy link

Having a config will enable cross-team workflows by providing a consistent configuration which can be stored in Git as part of onboarding, my personal preference would be for the config file to be yaml which has package integration with Go (link).

I'm picturing something like:

TTSModManager.config.yaml

---
paths:
  lua:
  - "./src"
  - "./other_src"
  - C:/Absolute/Path/Also
  xml:
  - "./xml"
  - "./other_src"
  - C:/Absolute/Path/Also
root_config: "./config.json"
moddir: C:/Some/Absolute/Path
modfile: "./output.json"
reverse: false
writesrc: true

(Paths being array to have multiple places to look for)

You could even have different configs for different purposes and call them by changing TTSModManager.exe --config X or Y

There's also the issue of where will this file be looked for, personally I think it should go from local to global. Something like, CMD flag overrides all, then look for it first next to the binary (./) and finally a static dir maybe in ~/.TTSModManager

I think this could be better handled by something like Configure which includes environment variable support

@argonui
Copy link
Owner Author

argonui commented Nov 29, 2022

Re: yml & Configure 100%

Re: local to global 100%

Re: multiple configs named X,Y etc, is that really any easier for the user than having different config files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants