Update latest value of OpenShiftRolloutPlugin in ConfigMap #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-4113
branch
2 times, most recently
from
63b9e20 to
ea759ef
Compare
chetan-rns
reviewed
Mar 26, 2024
controllers/configmap.go
Outdated
| return nil | ||
| if plugin.Location != r.OpenShiftRoutePluginLocation { | ||
| actualTrafficRouterPlugins[i].Location = r.OpenShiftRoutePluginLocation | ||
| pluginString, err := yaml.Marshal(actualTrafficRouterPlugins) |
There was a problem hiding this comment.
nit: pluginString is not a string here
Rizwana777
force-pushed
the
issue-4113
branch
2 times, most recently
from
54a7ebe to
56ef03a
Compare
Signed-off-by: Rizwana777 <[email protected]>
jgwest
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM too, thanks @Rizwana777, and thanks @chetan-rns for reviewing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it: