Keep the "library" namespace if it was specified in the image identifier #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ier. Fixes argoproj-labs#1012. Signed-off-by: Alessandro Zanatta <[email protected]>
AlessandroZanatta
requested review from
jannfis,
chengfang,
pasha-codefresh and
ishitasequeira
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1014 +/- ##
=======================================
Coverage 63.26% 63.26%
=======================================
Files 15 15
Lines 2243 2243
=======================================
Hits 1419 1419
Misses 733 733
Partials 91 91 ☔ View full report in Codecov by Sentry. |
AlessandroZanatta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented a change that should fix #1012.
Let me know if checking with
string.Containsis enough. It theoretically does not comply with the OCI specification, as it assumes that there is a single namespace, but most registries do not allow nested namespaces (ref).