feat: Add finalizers subresource to ArgoCDRole and ArgoCDRoleBindin…
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g CRDs - Updated ArgoCDRole and ArgoCDRoleBinding CustomResourceDefinitions to include `finalizers` as a subresource. - Enables separate RBAC permissions for managing finalizers on `argocdroles` and `argocdrolebindings` without requiring full update permissions on the main resources. Signed-off-by: Filip Rafaj <[email protected]>
|
Hi @filiprafaj, can u provide some details on the error? And preferably a way to reproduce it :) Thank you! |
|
The information about finalizers is saved in CRs metadata as of yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Controllers were unable to manage finalizers on
ArgoCDRoleandArgoCDRoleBindingresources due to missing subresource support in the CRDs, resulting e.g. in the following error:Solution
Updated the
ArgoCDRoleandArgoCDRoleBindingCRDs to includefinalizersas a subresource, allowing more granular RBAC permissions to manage finalizers without requiring full update access on the main resources.