From f7719749cf0c75ac34907318e510624ea49d150d Mon Sep 17 00:00:00 2001 From: Zach Aller Date: Mon, 23 Dec 2024 16:56:03 -0600 Subject: [PATCH] fix: remove space file name Signed-off-by: Zach Aller --- .github/workflows/ci.yaml | 2 +- Makefile | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index da414f10..6fe517e5 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -50,7 +50,7 @@ jobs: if: ${{ !cancelled() }} uses: codecov/codecov-action@v5.1.2 with: - files: cover.out, cover-go-unit.out + files: cover.out,cover-go-unit.out fail_ci_if_error: false env: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} diff --git a/Makefile b/Makefile index 8c2e4c32..084fc98a 100644 --- a/Makefile +++ b/Makefile @@ -1,3 +1,4 @@ +CURRENT_DIR=$(shell pwd) # Image URL to use all building/pushing image targets IMG ?= quay.io/argoprojlabs/gitops-promoter:latest # ENVTEST_K8S_VERSION refers to the version of kubebuilder assets to be downloaded by envtest binary. @@ -79,7 +80,7 @@ vet: ## Run go vet against code. go vet ./... .PHONY: test -test: manifests generate fmt vet envtest ## Run Ginkgo tests using go test, we prefer to use test-parallel but this target is nice because it dose not require ginkgo cli. +test: test-deps ## Run Ginkgo tests using go test, we prefer to use test-parallel but this target is nice because it dose not require ginkgo cli. KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test -run TestControllersGinkgo ./... -coverprofile cover.out .PHONY: go-unit-test