Add support for templatePatch #499
Conversation
Signed-off-by: AvivGuiser <[email protected]>
KyriosGN0
requested review from
oboukili,
onematchfox,
blakepettersson,
the-technat and
mkilchhofer
as code owners
|
Hint: Since you changed the schema for |
Signed-off-by: AvivGuiser <[email protected]>
|
@the-technat ran make generate, thx! |
Signed-off-by: AvivGuiser <[email protected]>
|
@the-technat i pushed a commit that should have fixed the tests |
|
@KyriosGN0 it looks like the tests fail for 2.9. I'm pretty sure that's because templatePatch support was added in 2.10. Glancing at the code it looks though as if you have added logic to not use this feature if the server is 2.9. Could you reverify this? In my opinion since it's a feature supported in the last three minor versions we shouldn't have to spend too much time trying to get the tests green on 2.9 which is unsupported anyways. Instead we might want to wait for #472 which will remove 2.9 from the CI anyways. This just as a hint to make it easier for you 😄 |
|
@the-technat yeah i tried and it failed, will take a look in a couple of days and will test locally, thx! |
Signed-off-by: AvivGuiser <[email protected]>
|
@the-technat should work now |
|
I see, thanks @KyriosGN0 for your work! Will do some manual tests this weekend as you suggested and give it a final review... |
closes #368
still needs some manual testing