-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter for Uno #406
Comments
I'm taking a look at this one. I'm currently planning on putting together a PR that exposes the Let me know if you feel strongly, @argyleink! |
thanks jeff! great thoughts. I'd originally imagined a sub-export yeah, something like for the |
I'm learning a bit more about how This changes how I'm going to structure the exported configuration a bit, but it makes sense since |
@argyleink following on from our discussion on #423, I wanted to make sure of a couple of things first. In my over simplified understanding about the work @jeffposnick started on #423, the Example
op-color-violet-4 {
color: #9775fa;
} More rules in the preset would extrapolate OP custom properties into its respective atomic CSS classes. Atomic CSS Class PrefixWhat do you think of having the atomic class prefix be configurable via the preset, but we also provide a default to EDIT: Thinking about the default some more I realised some folks might not want a prefix at all! Maybe the default is to not have a prefix? Prefix could be useful if you have a CSS class name clash; maybe you're using OP with Tailwind or something. The inverse of this is that when there isn't a likelihood of a name clash, then omitting the prefix makes sense. Example import { defineConfig } from 'unocss'
import openPropsPreset from "open-props/presets/uno";
export default defineConfig({
presets: [
openPropsPreset({
prefix: 'ops', // default value is 'op'
}),
],
}) Yields atomic CSS classes with the ops-color-violet-4 { } Or, with the default value of op-color-violet-4 { } It's lines up nicely with the customisability of a build. The following taken from the docs
TODOsHere is a list of todo items with the one's Jeff addressed and of which is still to be done
|
Sounds good! Everything in the comment is on point 🤘💀 |
@argyleink I'm unable to continue work on the Uno preset. I have stretched myself too thin time wise. I'm so sorry for committing and not being able to finish it :-( |
No worries @bjorntheart, appreciate the honesty and I'm very familiar with the feeling. |
@argyleink I've thought about this a lot, and found a way forward where I can still contribute, but not neglect my responsibilities at home. I'll pick this up again :-) |
https://unocss.dev/presets/community
The text was updated successfully, but these errors were encountered: